Skip to content

Conversation

@avandecreme
Copy link
Contributor

Description

This is an attempt to fix #316. I am not super happy with that fix because it effectively makes the sbml namespace reserved but I don't have a better idea.

Motivation and Context

Fix #316

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this. We should indeed not add two sbml namespaces.

@fbergmann fbergmann merged commit 6634325 into sbmlteam:development Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversion failure in v5.20.0

2 participants