Fix bug in SBMLTransforms::replaceFD
#303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `ASTNode::replaceArguments` to replace all arguments at the same time - refactor shared functionality into `copyNode` - modify `SBMLTransforms::replaceBvars` to use this instead of replacing arguments sequentially
fbergmann
approved these changes
Mar 14, 2023
Member
fbergmann
left a comment
fbergmann
left a comment
There was a problem hiding this comment.
that does look better, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ASTNode::replaceArgumentswhich replaces all supplied arguments at the same timeSBMLTransforms::replaceBvarsto use this instead of replacing arguments sequentiallycopyNodeMotivation and Context
SBMLTransforms::replaceFDgave incorrect results in some cases.This was due to
SBMLTransforms::replaceBvarsreplacing each bvar sequentially (#299)This PR instead substitutes all bvars simultaneously to avoid these incorrect results.
Types of changes
Checklist:
Testing