Skip to content

Conversation

@skeating
Copy link
Member

@skeating skeating commented Oct 29, 2022

Description

Adding fbc v3support to matlab

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating marked this pull request as ready for review December 21, 2022 10:23
@skeating skeating requested a review from fbergmann December 21, 2022 10:23
@fbergmann
Copy link
Member

I'm trying to get the build going on my side, however I am encountering some issues. On my windows machine i get crashes (access violations) when running the tests, and a test failure (not sure whether they are related yet). Also the following test fails:

File: test-greek.xml
Reading  test-greek.xml
Printing  test-greek.xml
Document written
        <p>ɱ - some € symbolsβ śԈ</p> is Not equal to         <p>ɱ - some € symbolsβ śԈ</p>
Output of test-greek.xml failed

so i thought of linux to compile there, but there compilation fails with compiling with:

/home/bq_fbergmann/libsbml-fbc-v3-matlab/src/bindings/matlab/StructureFields.cpp: In member function ‘const string StructureFields::readString(const string&, unsigned int, unsigned int)’:
/home/bq_fbergmann/libsbml-fbc-v3-matlab/src/bindings/matlab/StructureFields.cpp:1774:13: error: ‘mxArrayToUTF8String’ was not declared in this scope; did you mean ‘mxArrayToString’?
 1774 |     value = mxArrayToUTF8String(mxField);
      |             ^~~~~~~~~~~~~~~~~~~
      |             mxArrayToString

but maybe that matlab version is too old.

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to have this in

thank you

@fbergmann fbergmann merged commit cbca453 into development Feb 13, 2023
@fbergmann fbergmann deleted the fbc-v3-matlab branch February 13, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants