Skip to content

Conversation

@skeating
Copy link
Member

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating requested a review from fbergmann September 17, 2022 13:26
@skeating skeating marked this pull request as ready for review September 17, 2022 13:26
@skeating
Copy link
Member Author

if you have a play - run through valgrind and either commit or send feedback that would begreat
its not finished

@skeating skeating merged commit a887844 into development Sep 27, 2022
@skeating skeating deleted the sk-old-bkup branch September 27, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants