Skip to content

Conversation

@Dan1lD
Copy link
Collaborator

@Dan1lD Dan1lD commented Mar 21, 2022

No description provided.

@Dan1lD Dan1lD changed the title SmartRating actions feature/smartrating_actions Mar 21, 2022
action = AskRatingAction(items)
result = action.run(user, None)
self.assertEqual(expected[0].name, result[0].name)
self.assertEqual(expected[0].payload, result[0].payload)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я бы еще добавил для надежности:

self.assertEqual(expected[0].request_data, result[0].request_data)

Copy link
Collaborator

@SyrexMinus SyrexMinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тесты немного можно отредачить и доку для технического писателя надо бы написать

action = CallRatingAction(items)
result = action.run(user, None)
self.assertEqual(expected[0].name, result[0].name)
self.assertEqual(expected[0].payload, result[0].payload)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я бы еще добавил для надежности:

self.assertEqual(expected[0].request_data, result[0].request_data)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants