feat(plasma-icons): Add icons for `24 dp` from A to E #1164

neretin-trike · 2022-03-29T08:39:54Z

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @sberdevices/demo-canvas-app@0.68.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-b2c@1.54.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-icons@1.73.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-temple@1.48.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-ui@1.91.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-web@1.89.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/showcase@0.110.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-temple-docs@0.13.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-ui-docs@0.59.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-web-docs@0.47.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
npm install @sberdevices/plasma-website@0.44.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
# or 
yarn add @sberdevices/demo-canvas-app@0.68.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-b2c@1.54.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-icons@1.73.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-temple@1.48.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-ui@1.91.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-web@1.89.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/showcase@0.110.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-temple-docs@0.13.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-ui-docs@0.59.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-web-docs@0.47.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0
yarn add @sberdevices/plasma-website@0.44.0-canary.1164.c60e8646b04b94770ca88eb290dca7040245a66e.0

SberDevices-Eva · 2022-03-29T08:55:57Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1164/

SberDevices-Eva · 2022-03-29T09:08:24Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1164/
ui storybook: http://plasma.sberdevices.ru/pr-1164/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1164/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1164/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1164/temple-storybook/

codecov · 2022-03-29T09:18:03Z

Codecov Report

Merging #1164 (8ae7f44) into master (e6b77fc) will increase coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
+ Coverage   89.06%   89.52%   +0.45%     
==========================================
  Files         433      414      -19     
  Lines        5891     5574     -317     
  Branches     1693     1611      -82     
==========================================
- Hits         5247     4990     -257     
+ Misses        643      583      -60     
  Partials        1        1

Flag	Coverage Δ
plasma-b2c	`95.86% <ø> (ø)`
plasma-core	`94.95% <ø> (ø)`
plasma-temple	`82.45% <ø> (+0.15%)`	⬆️
plasma-ui	`94.42% <ø> (ø)`
plasma-web	`96.11% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/plasma-temple/src/utils/scroll.ts	`0.00% <0.00%> (-82.36%)`	⬇️
...age/components/ItemMainSection/ItemMainSection.tsx	`70.58% <0.00%> (-19.42%)`	⬇️
.../src/components/StateLayout/StateLayout@mobile.tsx	`94.73% <0.00%> (-5.27%)`	⬇️
...ages/plasma-temple/src/pages/ItemPage/ItemPage.tsx	`85.18% <0.00%> (ø)`
...ges/plasma-temple/src/registry/registry@sberbox.ts	`100.00% <0.00%> (ø)`
...es/plasma-temple/src/pages/ErrorPage/ErrorPage.tsx	`100.00% <0.00%> (ø)`
.../plasma-temple/src/registry/registry@sberportal.ts	`100.00% <0.00%> (ø)`
...-temple/src/pages/GridPage/components/GridCard.tsx	`100.00% <0.00%> (ø)`
.../src/components/StateLayout/StateLayout@common.tsx	`100.00% <0.00%> (ø)`
...src/components/StateLayout/StateLayout@sberbox.tsx	`100.00% <0.00%> (ø)`
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a4370...8ae7f44. Read the comment docs.

SberDevices-Eva · 2022-03-30T06:06:27Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1164/

SberDevices-Eva · 2022-03-30T06:29:13Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1164/
ui storybook: http://plasma.sberdevices.ru/pr-1164/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1164/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1164/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1164/temple-storybook/

SberDevices-Eva · 2022-03-30T13:31:17Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1164/

SberDevices-Eva · 2022-03-30T13:53:20Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1164/
ui storybook: http://plasma.sberdevices.ru/pr-1164/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1164/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1164/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1164/temple-storybook/

Yeti-or

нужно обсудить нейминг по всем outline; @gbushnev

Yeti-or · 2022-04-11T15:24:25Z

packages/plasma-icons/src/scalable/Icon.assets.24/AccessibilityFill.tsx

+
+import { IconProps } from '../IconRoot';
+
+export const AccessibilityFill: React.FC<IconProps> = (props) => (


это точно fill ?

Yeti-or · 2022-04-11T15:25:42Z

packages/plasma-icons/src/scalable/Icon.assets.24/AddToCallFill.tsx

+
+import { IconProps } from '../IconRoot';
+
+export const AddToCallFill: React.FC<IconProps> = (props) => (


черт кривое како-ето название, это точно про call ?

Yeti-or · 2022-04-11T15:26:23Z

packages/plasma-icons/src/scalable/Icon.assets.24/AddToCallFill.tsx

+        />
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


только clip

Yeti-or · 2022-04-11T15:29:52Z

packages/plasma-icons/src/scalable/Icon.assets.24/AlarmCircle.tsx

+        <g>
+            <path
+                fillRule="evenodd"
+                clipRule="evenodd"


только clip

Yeti-or · 2022-04-11T15:30:20Z

packages/plasma-icons/src/scalable/Icon.assets.24/AppsFill.tsx

+
+import { IconProps } from '../IconRoot';
+
+export const AppsFill: React.FC<IconProps> = (props) => (


тут тоже хочу про нейминг услышать

Yeti-or · 2022-04-11T17:37:39Z

packages/plasma-icons/src/scalable/Icon.assets.24/OtherDevices.tsx

+
+import { IconProps } from '../IconRoot';
+
+export const OtherDevices: React.FC<IconProps> = (props) => (


Yeti-or · 2022-04-11T17:38:33Z

packages/plasma-icons/src/scalable/Icon.assets.24/SberDevices.tsx

+
+import { IconProps } from '../IconRoot';
+
+export const SberDevices: React.FC<IconProps> = (props) => (


Мы не хотим это имя за нашим логосом зарезервировать ?

Yeti-or · 2022-04-11T17:39:16Z

packages/plasma-icons/src/scalable/Icon.assets.24/ShareMusic.tsx

+    <svg width="100%" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


Yeti-or · 2022-04-11T17:39:53Z

packages/plasma-icons/src/scalable/Icon.assets.24/Smarthome.tsx

+    <svg width="100%" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


Yeti-or · 2022-04-11T17:39:56Z

packages/plasma-icons/src/scalable/Icon.assets.24/Smarthome.tsx

+
+import { IconProps } from '../IconRoot';
+
+export const Smarthome: React.FC<IconProps> = (props) => (


neretin-trike requested a review from OgNellis as a code owner March 29, 2022 08:39

neretin-trike changed the title ~~feat(plasma-icon): Add icons for 24 dp from A to E~~ feat(plasma-icons): Add icons for 24 dp from A to E Mar 29, 2022

neretin-trike force-pushed the icon-export-tncjmunsut branch from 55d374b to 523511c Compare March 30, 2022 05:49

neretin-trike added 2 commits March 30, 2022 19:59

feat(plasma-icons): Add icons for 24 dp from A to E

ceb899f

feat(demo-canvas-app): Add scalable icons demo

8ae7f44

neretin-trike force-pushed the icon-export-tncjmunsut branch from 523511c to 8ae7f44 Compare March 30, 2022 12:59

neretin-trike requested review from LamaEats, VladislavPetyukevich, Yeti-or, fanisco and kvpolyanskiy as code owners March 30, 2022 12:59

neretin-trike added the v2.0 label Mar 30, 2022

Yeti-or reviewed Apr 11, 2022

View reviewed changes


		import { IconProps } from '../IconRoot';

		export const AccessibilityFill: React.FC<IconProps> = (props) => (


		import { IconProps } from '../IconRoot';

		export const AddToCallFill: React.FC<IconProps> = (props) => (


		import { IconProps } from '../IconRoot';

		export const AppsFill: React.FC<IconProps> = (props) => (


		import { IconProps } from '../IconRoot';

		export const OtherDevices: React.FC<IconProps> = (props) => (


		import { IconProps } from '../IconRoot';

		export const SberDevices: React.FC<IconProps> = (props) => (


		import { IconProps } from '../IconRoot';

		export const Smarthome: React.FC<IconProps> = (props) => (

feat(plasma-icons): Add icons for 24 dp from A to E #1164

Are you sure you want to change the base?

feat(plasma-icons): Add icons for 24 dp from A to E #1164

Uh oh!

Conversation

neretin-trike commented Mar 29, 2022 • edited by SberDevices-Eva Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SberDevices-Eva commented Mar 29, 2022

Uh oh!

SberDevices-Eva commented Mar 29, 2022

Uh oh!

codecov bot commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SberDevices-Eva commented Mar 30, 2022

Uh oh!

SberDevices-Eva commented Mar 30, 2022

Uh oh!

SberDevices-Eva commented Mar 30, 2022

Uh oh!

SberDevices-Eva commented Mar 30, 2022

Uh oh!

Yeti-or left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(plasma-icons): Add icons for `24 dp` from A to E #1164

feat(plasma-icons): Add icons for `24 dp` from A to E #1164

neretin-trike commented Mar 29, 2022 •

edited by SberDevices-Eva

Loading

codecov bot commented Mar 29, 2022 •

edited

Loading