Skip to content

Conversation

@didolf-sber
Copy link

@didolf-sber didolf-sber commented Feb 16, 2022

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @sberdevices/plasma-b2c@1.42.0-canary.1098.8fbb3c542d0f74c5a276570cba3c99903edd3f20.0
npm install @sberdevices/showcase@0.98.0-canary.1098.8fbb3c542d0f74c5a276570cba3c99903edd3f20.0
npm install @sberdevices/plasma-website@0.32.0-canary.1098.8fbb3c542d0f74c5a276570cba3c99903edd3f20.0
# or 
yarn add @sberdevices/plasma-b2c@1.42.0-canary.1098.8fbb3c542d0f74c5a276570cba3c99903edd3f20.0
yarn add @sberdevices/showcase@0.98.0-canary.1098.8fbb3c542d0f74c5a276570cba3c99903edd3f20.0
yarn add @sberdevices/plasma-website@0.32.0-canary.1098.8fbb3c542d0f74c5a276570cba3c99903edd3f20.0

@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1098/

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1098 (35076ac) into master (c2b3111) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files         346      346           
  Lines        4558     4558           
  Branches     1346     1346           
=======================================
  Hits         4010     4010           
  Misses        548      548           
Flag Coverage Δ
plasma-b2c 96.02% <100.00%> (ø)
plasma-core 94.90% <100.00%> (ø)
plasma-temple 73.81% <ø> (ø)
plasma-ui 94.47% <ø> (ø)
plasma-web 95.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/plasma-b2c/src/utils/selectText.ts 100.00% <ø> (ø)
...es/plasma-b2c/src/components/Editable/Editable.tsx 98.07% <100.00%> (ø)
...ckages/plasma-b2c/src/components/Slider/Double.tsx 100.00% <100.00%> (ø)
...ckages/plasma-b2c/src/components/Slider/Handle.tsx 97.36% <100.00%> (ø)
...ckages/plasma-b2c/src/components/Slider/Single.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dedde1d...35076ac. Read the comment docs.

@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1098/

@SberDevices-Eva
Copy link
Collaborator

@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1098/

@SberDevices-Eva
Copy link
Collaborator

export interface EditableProps {
value?: string;
onChange?: React.ChangeEventHandler<RefElement>;
onChange?: React.FormEventHandler<HTMLDivElement>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а почему именно FormEventHandler?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants