Skip to content

Commit 504c86f

Browse files
committed
[esm-integration] JSPI is not yet supported
I think I was confused at some point and thought that only ASYNCIFY=1 was not supported. Split out from emscripten-core#24555
1 parent 416fccc commit 504c86f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

test/common.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,6 +1123,8 @@ def require_jspi(self):
11231123
self.set_setting('JSPI')
11241124
if self.is_wasm2js():
11251125
self.skipTest('JSPI is not currently supported for WASM2JS')
1126+
if self.get_setting('WASM_ESM_INTEGRATION'):
1127+
self.skipTest('WASM_ESM_INTEGRATION is not compatible with JSPI')
11261128

11271129
if self.is_browser_test():
11281130
if 'EMTEST_SKIP_JSPI' in os.environ:

tools/link.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -808,8 +808,8 @@ def phase_linker_setup(options, linker_args): # noqa: C901, PLR0912, PLR0915
808808
exit_with_error('WASM_ESM_INTEGRATION requires MODULARIZE=instance')
809809
if settings.RELOCATABLE:
810810
exit_with_error('WASM_ESM_INTEGRATION is not compatible with dynamic linking')
811-
if settings.ASYNCIFY == 1:
812-
exit_with_error('WASM_ESM_INTEGRATION is not compatible with -sASYNCIFY=1')
811+
if settings.ASYNCIFY:
812+
exit_with_error('WASM_ESM_INTEGRATION is not compatible with -sASYNCIFY')
813813
if settings.WASM_WORKERS or settings.PTHREADS:
814814
exit_with_error('WASM_ESM_INTEGRATION is not compatible with multi-threading')
815815
if settings.USE_OFFSET_CONVERTER:

0 commit comments

Comments
 (0)