[esm-integration] Add pthread support #24555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a way to make it work! Not pretty, but it works! |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 12, 2025
I think I was confused at some point and thought that only ASYNCIFY=1 was not supported. Split out from emscripten-core#24555
sbc100
force-pushed
the
esm_integration_pthread
branch
3 times, most recently
from
1233179 to
967f7fa
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 12, 2025
I think I was confused at some point and thought that only ASYNCIFY=1 was not supported. Split out from emscripten-core#24555
sbc100
force-pushed
the
esm_integration_pthread
branch
from
967f7fa to
cf8e793
Compare
sbc100
added a commit
that referenced
this pull request
Jun 13, 2025
I think I was confused at some point and thought that only ASYNCIFY=1 was not supported. Split out from #24555
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 13, 2025
This function doesn't need to take an argument or be declared in closure externs anymore. Split out from emscripten-core#24555
sbc100
added a commit
that referenced
this pull request
Jun 13, 2025
This function doesn't need to take an argument or be declared in closure externs anymore. Split out from #24555
sbc100
force-pushed
the
esm_integration_pthread
branch
from
cf8e793 to
18d5a3a
Compare
sbc100
force-pushed
the
esm_integration_pthread
branch
2 times, most recently
from
9da3bec to
b10d786
Compare
|
This change has now been simplified a lot. I think its good to go now. PTAL |
kripken
reviewed
Jun 13, 2025
src/postamble.js
Outdated
| // When run as a worker thread run `init` immediately. | ||
| if ({{{ ENVIRONMENT_IS_WORKER_THREAD() }}}) await init() | ||
| if ({{{ ENVIRONMENT_IS_WORKER_THREAD() }}}) init() |
There was a problem hiding this comment.
Suggested change
| if ({{{ ENVIRONMENT_IS_WORKER_THREAD() }}}) init() | |
| if ({{{ ENVIRONMENT_IS_WORKER_THREAD() }}}) init(); |
There was a problem hiding this comment.
Reverted this line.
sbc100
force-pushed
the
esm_integration_pthread
branch
from
b10d786 to
79d4b0b
Compare
kripken
approved these changes
Jun 13, 2025
Under ESM integration all dependencies must be satisfied at import time, but pthreads requires that we have supply the memory via postMessage, so the memory is, by definition, not available at import time. On order to work around this issue we create a smaller pthread stub/loader file that delays the import of the main program until the initial `postMessage` has been received. Once the memory is received we load main program using a dynamic `import` statement.
sbc100
force-pushed
the
esm_integration_pthread
branch
from
79d4b0b to
968bbbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under ESM integration all dependencies must be satisfied at import time, but pthreads requires that we have supply the memory via postMessage, so the memory is, by definition, not available at import time.
On order to work around this issue we create a smaller pthread stub/loader file that delays the import of the main program until the initial
postMessagehas been received. Once the memory is received we load main program using a dynamicimportstatement.