Skip to content

Commit

Permalink
KEYS: Use the symbol value for list size, updated by scripts/insert-s…
Browse files Browse the repository at this point in the history
…ys-cert

When a certificate is inserted to the image using scripts/writekey, the
value of __cert_list_end does not change. The updated size can be found
out by reading the value pointed by the system_certificate_list_size
symbol.

Signed-off-by: Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
Signed-off-by: David Howells <dhowells@redhat.com>
  • Loading branch information
mkayaalp authored and dhowells committed Feb 26, 2016
1 parent c4c3610 commit 8e16789
Showing 1 changed file with 21 additions and 8 deletions.
29 changes: 21 additions & 8 deletions scripts/extract-sys-certs.pl
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,15 @@ (@)

die "Can't find system certificate list"
unless (exists($symbols{"__cert_list_start"}) &&
exists($symbols{"__cert_list_end"}));
exists($symbols{"system_certificate_list_size"}));

my $start = Math::BigInt->new($symbols{"__cert_list_start"});
my $end = Math::BigInt->new($symbols{"__cert_list_end"});
my $size = $end - $start;
my $end;
my $size;
my $size_sym = Math::BigInt->new($symbols{"system_certificate_list_size"});

printf "Have %u bytes of certs at VMA 0x%x\n", $size, $start;
open FD, "<$vmlinux" || die $vmlinux;
binmode(FD);

my $s = undef;
foreach my $sec (@sections) {
Expand All @@ -110,11 +112,24 @@ (@)
next unless ($start >= $s_vma);
next if ($start >= $s_vend);

die "Cert object partially overflows section $s_name\n"
if ($end > $s_vend);
die "Certificate list size was not found on the same section\n"
if ($size_sym < $s_vma || $size_sym > $s_vend);

die "Cert object in multiple sections: ", $s_name, " and ", $s->{name}, "\n"
if ($s);

my $size_off = $size_sym -$s_vma + $s_foff;
my $packed;
die $vmlinux if (!defined(sysseek(FD, $size_off, SEEK_SET)));
sysread(FD, $packed, 8);
$size = unpack 'L!', $packed;
$end = $start + $size;

printf "Have %u bytes of certs at VMA 0x%x\n", $size, $start;

die "Cert object partially overflows section $s_name\n"
if ($end > $s_vend);

$s = $sec;
}

Expand All @@ -127,8 +142,6 @@ (@)

printf "Certificate list at file offset 0x%x\n", $foff;

open FD, "<$vmlinux" || die $vmlinux;
binmode(FD);
die $vmlinux if (!defined(sysseek(FD, $foff, SEEK_SET)));
my $buf = "";
my $len = sysread(FD, $buf, $size);
Expand Down

0 comments on commit 8e16789

Please sign in to comment.