Skip to content

Commit

Permalink
netfilter: ipset: add a coding-style fix to ip_set_ext_destroy.
Browse files Browse the repository at this point in the history
Use a local variable to hold comment in order to align the arguments of
ip_set_comment_free properly.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Acked-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
a3a3el authored and ummakynes committed Oct 7, 2019
1 parent fbe3d0c commit 017f77c
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions include/linux/netfilter/ipset/ip_set.h
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,11 @@ ip_set_ext_destroy(struct ip_set *set, void *data)
/* Check that the extension is enabled for the set and
* call it's destroy function for its extension part in data.
*/
if (SET_WITH_COMMENT(set))
ip_set_extensions[IPSET_EXT_ID_COMMENT].destroy(
set, ext_comment(data, set));
if (SET_WITH_COMMENT(set)) {
struct ip_set_comment *c = ext_comment(data, set);

ip_set_extensions[IPSET_EXT_ID_COMMENT].destroy(set, c);
}
}

static inline int
Expand Down

0 comments on commit 017f77c

Please sign in to comment.