Fix: Correct RUN command structure in Dockerfile#7
Open
CaptainRong wants to merge 1 commit intosbaresearch:masterfrom
Open
Fix: Correct RUN command structure in Dockerfile#7CaptainRong wants to merge 1 commit intosbaresearch:masterfrom
CaptainRong wants to merge 1 commit intosbaresearch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct Dockerfile RUN command structure for git install
Description:
This PR fixes the issue where the
apt-get install gitcommand was misplaced in the Dockerfile. Due to a missing continuation backslash (\) on the preceding line, this command was detached from the mainRUNinstruction block, causing the Docker build process to fail with a syntax error.Changes Made:
apt-get -y install gitstatement into the end of the first multi-lineRUNinstruction block.RUNblock, allowing it to execute correctly.Motivation and Context:
I get an error when doing make build on my archlinux and cannot continue to build
This fix is necessary because it resolves the syntax error that prevents the Docker image from being successfully built. After the fix, the Dockerfile can perform all dependency installation steps, including the installation of "git".
How Has This Been Tested?
I have successfully built the image based on the modified Dockerfile in my local environment (Arch Linux with Docker-desktop) using the command
make build-image. This confirmed thatgitwas installed correctly and subsequent steps (likegit clone) could be executedTypes of changes:
Checklist:
This is my first contribution attempt, and I hope it's helpful! Please let me know if any further changes are needed. Thank you! ^^