Make retrieval of file size more portable#234
Open
saxbophone wants to merge 4 commits intodevelopfrom
Open
Conversation
The Windows version is a work in progress...
saxbophone
commented
Jan 27, 2019
| // return the calculated file size | ||
| return SXBP_RESULT_OK; | ||
| } | ||
| #endif |
Owner
Author
There was a problem hiding this comment.
I don't like this generic version. It does things in a fundamentally different way to the others. I think it should be removed instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put
sxbp_get_file_size()in a separate source file and used conditional compilation to provide three different implementations of it:fstat()GetFileSizeEx()(and associated other WinAPI functions)fseek()andSEEK_END, which isn't required to be supported meaningfully).TODO: