-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playing and polishing indexView #2365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...nd/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/IndexViewUserInfo.kt
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ktlint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
...nd/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/IndexViewUserInfo.kt
Fixed
Show fixed
Hide fixed
...nd/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/IndexViewUserInfo.kt
Fixed
Show fixed
Hide fixed
orchestr7
force-pushed
the
feature/brand-new-index
branch
from
July 23, 2023 22:58
458f6f2
to
30ef9bd
Compare
sanyavertolet
approved these changes
Jul 24, 2023
...frontend/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/CardAboutUs.kt
Outdated
Show resolved
Hide resolved
...tend/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/CardServiceInfo.kt
Outdated
Show resolved
Hide resolved
save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/CardUser.kt
Outdated
Show resolved
Hide resolved
...end/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/IndexLogoButtons.kt
Show resolved
Hide resolved
kgevorkyan
reviewed
Jul 24, 2023
save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/views/index/CardUser.kt
Show resolved
Hide resolved
nulls
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of design (actually it is a little bit different when you are logged-in: you won't see a "Sign in with" menu). But I decided to show to logics on one screenshot.