Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A hot fix for processing expected file #573

Merged
merged 4 commits into from
Mar 12, 2024
Merged

A hot fix for processing expected file #573

merged 4 commits into from
Mar 12, 2024

Conversation

nulls
Copy link
Member

@nulls nulls commented Mar 12, 2024

What's done:

  • rewritten reading expected warnings in a single file

@nulls
A hot fix for processing expected file
fdbc1c2 
### What's done:
- rewritten reading expected warnings in a single file
@nulls nulls self-assigned this Mar 12, 2024
@nulls nulls requested review from kgevorkyan and orchestr7 and removed request for kgevorkyan March 12, 2024 08:57
orchestr7
orchestr7 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@orchestr7 orchestr7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

@nulls
Copy link
Member Author

nulls commented Mar 12, 2024 •
edited
Loading

Lgtm :)

I think we need to refactor WarnConfig and split it to different sub classes.
Now we have two groups of fields *IdxOut and *Idx: one of them for actual warning, the second one is for expected. It will be more readable to keep them on different level in config file and code

@nulls nulls enabled auto-merge (squash) March 12, 2024 09:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

JUnit Tests (Linux, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✅ ±0   7m 18s ⏱️ -49s
 48 suites ±0    24 💤 ±0 
 48 files   ±0     0 ❌ ±0 

Results for commit 23d57c2. ± Comparison against base commit 02e8d03.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✅ ±0   7m 34s ⏱️ - 2m 39s
 48 suites ±0    24 💤 ±0 
 48 files   ±0     0 ❌ ±0 

Results for commit 23d57c2. ± Comparison against base commit 02e8d03.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

245 tests  ±0   221 ✅ ±0   8m 59s ⏱️ - 1m 11s
 48 suites ±0    24 💤 ±0 
 48 files   ±0     0 ❌ ±0 

Results for commit 23d57c2. ± Comparison against base commit 02e8d03.

♻️ This comment has been updated with latest results.

@nulls nulls merged commit 7856434 into main Mar 12, 2024
10 checks passed
@nulls nulls deleted the bugfix/file_name_from_expected branch March 12, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 approved these changes

@kgevorkyan kgevorkyan kgevorkyan approved these changes

Assignees

@nulls nulls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nulls @kgevorkyan @orchestr7