Change swiftSegmentSize config from string to int. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was an error. I was using the wrong commit. The PR fixes the problem. |
|
Thanks @jbeales !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading a large object the
swiftSegmentSizeconfig option gets passed around until it gets used to create a GuzzleHttp\Psr7\LimitStream, where it must be an integer. Having it as a string causes aTypeError.I'm not sure when this changed, everything was working fine for me, but I updated some dependencies today and must have pulled in a new version of of either sausin/laravel-ovh or php-opencloud/openstack, and now the types don't agree.
It might be logical to change the
swiftLargeObjectThresholdas an integer too, but it is not causing any problems as a string so I didn't change it.