-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade web-ext from 4.3.0 to 9.2.0 #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…abilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TMP-11501554 - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the security posture of the project by automatically updating a key dependency, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades the web-ext dependency from version 4.3.0 to 9.2.0 to resolve two medium-severity vulnerabilities. While the security fix is important, this is a major version upgrade across five versions, which introduces a high risk of breaking changes. My review highlights a critical concern regarding the new Node.js version requirement (v18.12.0+) for web-ext v9, which could break the development and CI environments if the project supports older Node versions. Additionally, other breaking changes in the web-ext CLI could affect build and test scripts. It is essential to perform thorough manual testing before merging this change.
| }, | ||
| "dependencies": { | ||
| "web-ext": "^4" | ||
| "web-ext": "^9.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR upgrades web-ext across 5 major versions (from v4 to v9). This is a significant change that likely includes breaking changes, as indicated by Snyk's own metadata (isBreakingChange: true).
There are a couple of critical risks to consider:
- Node.js version requirement:
web-extv9 requires Node.js v18.12.0 or newer. If this project supports older versions of Node.js, this upgrade will break the build for developers and CI environments using those older versions. Please verify the project'senginesconfiguration and ensure compatibility. - Breaking changes in CLI: Major version updates often change command-line flags, configuration options, or behavior. The scripts that use
web-ext(e.g., foryarn test:firefox) may need to be updated.
Given that this is an automated PR, it is crucial to thoroughly test the Firefox extension's build and test scripts (yarn build:firefox, yarn test:firefox) to ensure everything still works as expected before merging.
Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
packages/react-devtools-extensions/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-TMP-11501554
SNYK-JS-INFLIGHT-6095116
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.