fix: infinite loop when :hover is contained in :has or nested :not selector #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for
:not()in 3433c7d was incomplete because it only considered:hoveras a standalone selector but missed the ability to combine it with other selectors like:not(.some-class:hover), yielding an infinite loop once again.The same problem exists for
:has()and since it follows the same semantics, I went ahead and unified the approach for both pseudo selectors. For complex selectors the:not()or:has()is not the immediate parent, requiring a recursive lookup to identify any such selectors.Fixes #35