feat(*): add support for wrapping chrome.runtime.port objects
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
requested changes
Mar 14, 2019
Owner
satya164
left a comment
satya164
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left few small comments
| /* @flow */ | ||
|
|
||
| export type Worker = { | ||
| export type Target = { |
Owner
There was a problem hiding this comment.
Maybe it should be like Worker | ChromeRuntimePort? Right now the type requires the methods to exist even if we don't use them
| }; | ||
|
|
||
| target.addEventListener('message', listener); | ||
| if (target.onMessage) { |
Owner
There was a problem hiding this comment.
Can we add a comment mentioning which environment this handles?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.