-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discord): support sending voice messages #264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 86.88% 86.93% +0.04%
==========================================
Files 1 1
Lines 549 551 +2
Branches 111 112 +1
==========================================
+ Hits 477 479 +2
Misses 72 72 ☔ View full report in Codecov by Sentry. |
content: '', | ||
attachments: [ | ||
{ | ||
waveform: '', // base64 encoded bytearray representing a sampled waveform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the waveform
be required here to be calculated from the wave ?
From Discord's doc:
The
waveform
is intended to be a preview of the entire voice message, with 1 byte per datapoint encoded in base64. Clients sample the recording at most once per 100 milliseconds, but will downsample so that no more than 256 datapoints are in the waveform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also possible to send without calculation.
Co-authored-by: Maiko Sinkyaet Tan <maiko.tan.coding@gmail.com>
No description provided.