Add Elasticsearch authentication #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.es = Elasticsearch( | ||
| Paras.elasticsearch_url | ||
| ) | ||
| if Paras.elasticsearch_user is None or Paras.elasticsearch_pass is None: |
There was a problem hiding this comment.
The current check treats the scenario where only one credential is provided as if authentication is not needed, which could lead to unexpected behavior. Consider adding a validation that requires both ELASTICSEARCH_USER and ELASTICSEARCH_PASS to be set, or raise an error if only one is provided.
Suggested change
| if Paras.elasticsearch_user is None or Paras.elasticsearch_pass is None: | |
| if (Paras.elasticsearch_user is None) != (Paras.elasticsearch_pass is None): | |
| logger.error("Both ELASTICSEARCH_USER and ELASTICSEARCH_PASS must be set, or neither should be set.") | |
| raise ValueError("Invalid Elasticsearch credentials configuration.") | |
| if Paras.elasticsearch_user is None and Paras.elasticsearch_pass is None: |
| satomic/cpuad-updater | ||
| ``` | ||
| If your Elasticsearch instance requires authentication, pass include the `ELASTICSEARCH_USER` and `ELASTICSEARCH_PASS` environment variables. |
There was a problem hiding this comment.
[nitpick] Consider rephrasing the sentence for clarity, e.g., 'If your Elasticsearch instance requires authentication, include the ELASTICSEARCH_USER and ELASTICSEARCH_PASS environment variables.'
Suggested change
| If your Elasticsearch instance requires authentication, pass include the `ELASTICSEARCH_USER` and `ELASTICSEARCH_PASS` environment variables. | |
| If your Elasticsearch instance requires authentication, include the `ELASTICSEARCH_USER` and `ELASTICSEARCH_PASS` environment variables. |
Owner
|
reviewed, merged |
Contributor
Author
|
I pulled your latest docker image. Both of my issues are fixed. Thanks for your awesome work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using an authenticated version of Elasticsearch. This adds the ability to pass in
ELASTICSEARCH_USERandELASTICSEARCH_PASS. If they are not set, it falls back on the original non-authenticated Elasticsearch.If you want to test, I have an image on DockerHub,
rprouse/cpuad-updater:20250410