Fixed issue [#139]#310
Open
mawen12 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the user selects
systemas their theme preference, themeta[name='theme-color']tag always sets its content to '#fff' (light mode color), regardless of the operating system's actual color scheme. This causes the browser address bar / tab bar color to mismatch the actual page theme.The root cause is that the code uses the theme state (which can be
light,dark, orsystem) instead of resolvedTheme (which is alwayslightordarkafter evaluating the system preference). When theme ===system, the ternary expression theme ===dark? '#020817' : '#fff' always evaluates to '#fff', even if the OS is in dark modeTypes of changes
Checklist
Further comments
Related Issue
Closes: #309