Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore REST all mod versions response contents #82

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

mircearoata
Copy link
Member

Since the ent refactor, the dependencies list was null, and a lot of blank fields were returned, because a GraphQL response type was used, but was not filled in.

Also adds a Link field to the targets in the response, like the Link in the Version type on the GraphQL API, such that ficsit-resolver doesn't need to construct the downloads links based on the version ID and target name.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 19.83%. Comparing base (d13695d) to head (8a18a0a).
Report is 1 commits behind head on staging.

Files Patch % Lines
generated/conv/version.go 0.00% 48 Missing ⚠️
conversion/ent_to_rest.go 0.00% 4 Missing ⚠️
nodes/mod.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging      #82      +/-   ##
===========================================
- Coverage    19.84%   19.83%   -0.02%     
===========================================
  Files          229      230       +1     
  Lines        57102    57154      +52     
===========================================
  Hits         11334    11334              
- Misses       43303    43355      +52     
  Partials      2465     2465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vilsol Vilsol merged commit 7cb4de8 into staging Aug 13, 2024
6 of 10 checks passed
@Vilsol Vilsol deleted the rest-all-mods-fix branch August 13, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants