Measure and log the time used to remove all child directories (uber-a…

…rchive#335)

Cleanup step when moving between stages can take time, and this time is not being logged anywhere. This log will expose the time used to remove memfs files.

lib/snapshot/utils.go

@@ -23,6 +23,7 @@ import (
 	"os"
 	"path/filepath"
 	"strings"
+	"time"
 
 	"github.com/uber/makisu/lib/log"
 	"github.com/uber/makisu/lib/mountutils"
@@ -119,13 +120,15 @@ func removePathRecursive(p string, fi os.FileInfo, blacklist []string) bool {
 // removeAllChildren recursively removes all of the files that it can under the given root.
 // It skips paths in the given blacklist and continues when it fails to remove a file.
 func removeAllChildren(srcRoot string, blacklist []string) error {
+	start := time.Now()
 	children, err := ioutil.ReadDir(srcRoot)
 	if err != nil {
 		return fmt.Errorf("failed to get children of %s: %s", srcRoot, err)
 	}
 	for _, child := range children {
 		removePathRecursive(filepath.Join(srcRoot, child.Name()), child, blacklist)
 	}
+	log.Infow(fmt.Sprintf("* Removed %d directories under %s", len(children), srcRoot), "duration", time.Since(start).Round(time.Millisecond))
 	return nil
 }