fix(exporters): added save output button on rendered output #1664
Conversation
Signed-off-by: Kishan Patel <kpatel7927@gmail.com>
DCO Remediation Commit for Kishan Patel <kpatel7927@gmail.com> I, Kishan Patel <kpatel7927@gmail.com>, hereby add my Signed-off-by to this commit: 9e382a1 Signed-off-by: Kishan Patel <kpatel7927@gmail.com>
kpatl1
changed the title
|
I can see that the button is easier for an end user to find and simply click than a context menu. |
…on hover Signed-off-by: Kishan Patel <kpatel7927@gmail.com>
|
I have gone in and added the suggestion with the on hover toolbar similar to the code cells. I believe this may be the most intuitive because it shares similar functionality as the other cells in the notebook. Let me know what you think! |
|
I tried it and it still covers the content. And, where is the icon from? To me, it doesn't look like the save/export or related icon we are familiar with. |
Signed-off-by: Kishan Patel <kpatel7927@gmail.com>
I added in a negative top, let me know what you think. I was also thinking of maybe adding it to the code cell toolbar instead what are your thoughts on that? I have also adjusted the icon to get one from the VSCode library. |
|
It looks good in HTML output but not Log output. It's covered by code cell above. Regarding code cell toolbar, I think directly in output cell (your current approach) is better. |
Signed-off-by: Kishan Patel <kpatel7927@gmail.com>
|
Gotcha, I have gone and fixed the log output negative top as well. |
|
When content is wide, the button still scrolls with the content. |
| if (!cell) { | ||
| return; | ||
| } | ||
| let timesOutputSaved = 0; |
There was a problem hiding this comment.
it looks like this one is global. So if I just save another notebook, the notebook name is different but the count simply added which may look weird.
In my opinion it's not necessary to manage a count. If a name duplicated, system will prompt the user to change a name, right?
| // SPDX-License-Identifier: Apache-2.0 | ||
| import type { ActivationFunction } from "vscode-notebook-renderer"; | ||
|
|
||
| let outputIndex = 0; |
There was a problem hiding this comment.
looks like this one is global. So if I switch between multiple notebooks the output index will be wrong?
| `; | ||
|
|
||
| const saveButton = document.createElement("button"); | ||
| saveButton.title = "Save Output"; |
| container.style.position = "relative"; | ||
|
|
||
| if (context.postMessage) { | ||
| const toolbar = document.createElement("div"); |
There was a problem hiding this comment.
are you able to re-use some code with HTMLRenderer?
|
For keyboard accessibility, when I keyboard focus on the button, the button should be visible. |
Summary:
added a confirmation dialog that shows which cell's output will be saved and instructs users to click on the desired cell first before using "Save Output"
Testing:
Created new Sasnb file and tried to save output from two different cells.
TODOs:
Fixes #1648