Skip to content

docs: Correct database_flags syntax for Postgres servers (PSKD-1437) #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

dhoucgitter
Copy link
Member

Changes

  • Update the example postgres servers database_flags value to fix the invalid syntax and include two working example name/value pairs that can be used to set database_flags correctly.

Tests

  • After duplicating the error message noted in the internal ticket with the existing documentation format for database_flags, I updated the database_flags value for the default postgres server instance to use the format below that includes commas between name/value pairs and between each database_flags entry as required.
postgres_servers = {    
  default = {    
    database_flags         = [{ name = "cloudsql.enable_pg_cron", value = "true"}, { name = "cloudsql.enable_pgaudit", value = "true"}] 
  },    
}     
  • I checked the created postgres server instance in the GCP console to verify that both the cloudsql.enable_pg_cron and cloudsql.enable_pgaudit database flags were set to "on" as expected.

Signed-off-by: David.Houck <David.Houck@sas.com>
@dhoucgitter dhoucgitter added the documentation Improvements or additions to documentation label Mar 26, 2025
@dhoucgitter dhoucgitter self-assigned this Mar 26, 2025
@dhoucgitter dhoucgitter changed the title docs: Correct database_flags syntax for postgres servers (PSKD-1437) docs: Correct database_flags syntax for Postgres servers (PSKD-1437) Mar 26, 2025
@dhoucgitter dhoucgitter merged commit f034f5b into staging Mar 27, 2025
4 checks passed
@dhoucgitter dhoucgitter deleted the pr-pskd-1437 branch March 27, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants