Skip to content

Conversation

@kozak1c
Copy link

@kozak1c kozak1c commented Nov 3, 2025

…e options. Add MS OCR model name (available when Microsoft is selected as the OCR engine)Add MS OCR model name (available when Microsoft is selected as the OCR engine). Remove optional setting to maintain directory structure.

Please include answers to these questions as part of your pull request

In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

  • Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).
    • Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
    • No
  • Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.
    • My contribution does NOT include PII data
    • My contribution includes PII data
  • Q3: Confirm your contribution does not include any encryption or other export-controlled technology.
    • My contribution does NOT contain encryption or other export-controlled technology
    • My contribution includes encryption or other export-controlled technology

ContributorAgreement.txt

…e options. Add MS OCR model name (available when Microsoft is selected as the OCR engine)Add MS OCR model name (available when Microsoft is selected as the OCR engine). Remove optional setting to maintain directory structure.

Signed-off-by: Corey Kozak <corey.kozak@sas.com>
@Criptic Criptic self-requested a review November 4, 2025 07:11
@Criptic Criptic self-assigned this Nov 4, 2025
@Criptic Criptic added the enhancement New feature or request label Nov 4, 2025
@snlwih
Copy link
Collaborator

snlwih commented Nov 4, 2025

Feedback provided by @Criptic

  1. Please add the Changelog that you have added to the step also to the README file.
  2. Your step contains a mixture of TAB and Spaces please use one consistently within the code.

And I have one suggestion: The explainer text at the beginning of the Options pages states that the files should be located on the server file system (not in SAS Content) – I’d recommend changing this to: should be located on the SAS Server file system (not in SAS Content). – this change would also align with the error messages that the code throws, if the content is in SAS Content.

@snlwih
Copy link
Collaborator

snlwih commented Nov 4, 2025

And one additional remark from my side: When implementing those changes make sure you also update the date in your changelog (About tab in step itself and in the README.md). This is a common oversight when contributors implement feedback ;-)

Signed-off-by: Corey Kozak <corey.kozak@sas.com>
@kozak1c
Copy link
Author

kozak1c commented Nov 4, 2025

Requested changes have been implemented. Ready for another review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants