Add specs for the handling of unit in for loops #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
changed the title
stof
commented
Jan 14, 2021
| <===> unit/to_unitless/options.yml | ||
| --- | ||
| :todo: | ||
| - libsass |
There was a problem hiding this comment.
the libsass behavior is to require the same unit rather than requiring compatible units. That's why these 3 specs are marked as TODO. I haven't created an issue on libsass for that given that it is deprecated.
There was a problem hiding this comment.
These should probably be ignore_for rather than todo since there's on expectation that LibSass will support them in the future.
There was a problem hiding this comment.
done.
Maybe the readme should be updated for its explanation of ignore_for as it is described as being used for deprecated features removed from modern implementation, not for modern features ignored for deprecated implementations. That's why I chose todo initially.
nex3
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently includes commits from #1615. This will get cleaned once it is merged.
Closes #1616
skip dart-sass