This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add a nice little progress bar while downloading binary #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
feat/progress-bar
branch
from
176b5b8
to
42f6fec
Compare
Forked from sass#1649. This PR adds a small ascii progress bar to the binary download. Stalled installations make up a steady background noise of our issues. It's my hope that by making the binary fetch more transparent we can stem the tide of those issues. In order to address @saper's [concerns][1] this progress bar will respect npm's `progress` config flag. Downloading ``` Start downloading binary at https://github.com/sass/node-sass/releases/download/v3.8.0/darwin-x64-48_binding.node Total 2602136 [=============== ] 1566256 60% 4.9s ``` Success ``` Start downloading binary at https://github.com/sass/node-sass/releases/download/v3.8.0/darwin-x64-48_binding.node Total 2602136 [=========================] 2602136 100% 0.0s Binary downloaded and installed at /tmp/node-sass/vendor/darwin-x64-48/binding.node ``` [1]: sass#1649 (comment)
xzyfer
force-pushed
the
feat/progress-bar
branch
from
42f6fec
to
e409176
Compare
xzyfer
force-pushed
the
feat/progress-bar
branch
from
6dc92d2
to
25b54a7
Compare
|
@nschonni taking your advice I've replaced the |
| @@ -56,6 +57,8 @@ function download(url, dest, cb) { | |||
| } | |||
| }; | |||
|
|
|||
| console.log('Start downloading binary at', url); | |||
There was a problem hiding this comment.
Was the console.log intentional? Not sure if the log.newGroup makes sense here
There was a problem hiding this comment.
Yes it was. The user wont get any progress output until we get a response which won't happen for things like connection timeouts.
Tracker groups not appear to produce any output. I could be wrong, the docs aren't useful.
|
Happy to iterate on this. For now I want to get 3.9.0 out before tagging the next libsass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from #1649.
This PR adds a small ascii progress bar to the binary download.
Stalled installations make up a steady background noise of our
issues. It's my hope that by making the binary fetch more
transparent we can stem the tide of those issues.
In order to address @saper's concerns this progress bar will
respect npm's
progressconfig flag.Closes #1649