[DNM] CMake build files and directory structure

[nschonni]

DO NOT MERGE

The commits really need to be cleaned up before this can be merged.

• Replace Make/autotools with CMake for cross platform building.
• Loose layout based on https://code.google.com/p/cpp-library-project-template/
• Each namespace moved to folders below src
• Adds version information
• Testing is invoked through CTest for now, but this only gives the full output for the specs when using the verbose flag
• Existing test harness under the test folder all pass currently because CTest expects a non-zero exit for failures
• Base setup for Doxygen generation, but not fully plumbed

TODO

• Rebase down commits
• Remove Boost/Unit++ commented out code
• Look at replacing GLOB_RECURS for tests
• Update all license top license lines with actual content
• Exclude generated version info file
• Emscripten binding using https://github.com/kripken/emscripten/blob/master/cmake/Platform/Emscripten.cmake

[QuLogic]

Why does this end here and not at the end?

[nschonni]

I will if all the #ifndef SASS's are replaced in the other files

[nschonni]

Thanks for the feedback @QuLogic! It's been a long time since I did C building, so I appreciate the pointers.

[nschonni]

PS: @QuLogic I've started to clean and rebase here https://github.com/nschonni/libsass/tree/src-files-cleanup and will push back to this PR once finished. Feel free to PR to that branch for any improvements

[nschonni]

@QuLogic I've rebased down if you want to have another look.

I still need to add back the emscripten target though

[QuLogic]

BTW, you seem to have left autotools in, this time around.

[QuLogic]

Also, can CMake be configured to disable testing (because maybe someone doesn't want to install Ruby)?

[nschonni]

Also, can CMake be configured to disable testing (because maybe someone doesn't want to install Ruby)?

Yup, that's what i did here https://github.com/hcatlin/libsass/pull/292/files#diff-15547c54d3d4898a882b4ab7b3cee381R21

[QuLogic]

Also, can CMake be configured to disable testing (because maybe someone doesn't want to install Ruby)?

Yup, that's what i did here https://github.com/hcatlin/libsass/pull/292/files#diff-15547c54d3d4898a882b4ab7b3cee381R21

Ah right, for some reason, I thought I saw a REQUIRED there.

[nschonni]

@QuLogic is is better to repack the test exes with the libsass.a or just copy the file to the bin folder for dynamic loading?

[QuLogic]

libsass.a is static, and must be built into everything that uses it. If you had a libsass.so, then you could load it dynamically. I think CMake should take care of that stuff for you, though.

[QuLogic]

I see a few warnings with Doxygen 1.8.6:

Warning: Tag `SYMBOL_CACHE_SIZE' at line 40 of file Doxyfile has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
Warning: Tag `SHOW_DIRECTORIES' at line 71 of file Doxyfile has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
Warning: Tag `HTML_ALIGN_MEMBERS' at line 130 of file Doxyfile has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
Warning: Tag `USE_INLINE_TREES' at line 153 of file Doxyfile has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
Warning: doxygen no longer ships with the FreeSans font.
You may want to clear or change DOT_FONTNAME.
Otherwise you run the risk that the wrong font is being used for dot generated graphs.

[QuLogic]

You should try testing an out-of-source build. (Lots of CMake-using projects prefer/mandate it.)

mkdir build
cd build
cmake ..
make

Documentation, for example, ends up in the source directory instead of the build directory. I'm not sure if the full test suite works (I don't have Ruby on this computer).

[nschonni]

I see a few warnings with Doxygen 1.8.6:

👍 ran the upgrade and moved it to the build directory

[mgreter]

Hey guys! Do you think this would still be a valuable addition to libsass, since we've added MSVC 2013 project files? Since MSVC 2013 is the only compiler that can compile libsass, I'm not sure if CMake would add much benefit. Currently I don't see much pain to handle all the different makefiles, since we are only adding a file to the build here and then. But we are laking a target to build a dll on MSVC currently though! So it still seems to be interesting ...

Are you guys up to rebase this to latest master? IMO it should be a bit easier and I agree that an out of source build would be better. I actually would volunteer to adjust the other build files accordingly. Shouldn't be too hard, since they are quite modular already.

[nschonni]

Yeah, I think there is still value and this should be simpler now that the Emscripten stuff has been removed. This likely needs to start from scratch as I also moved the source files in this making it painful to rebase.

PS: another good example of a cross platform lib leveraging it https://github.com/libgit2/libgit2/blob/master/CMakeLists.txt?ts=4

[am11]

👍
Another repo which has integrated CMake recently: https://github.com/neovim/neovim.

[mgreter]

I have picked up on this work and successfully built the dll with cmake and msbuild (#1352). Bot sure if it will make it to master anytime soon, but getting the first results was rather easy! But there are still some open things, like versions and header location. Maybe somebody wants to continue from there ...

Going to close this once I can create a clean PR with my changes!

[nschonni]

That's great @mgreter !

[mgreter]

I'm going to close this since it is superseded by #1359.