Clean up Selector_List::operator==
#2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
selector-list-eq
branch
from
80bdc55
to
7f43f0f
Compare
Implements equality for selector lists in a cleaner and more efficient manner. Related issue: sass#2666 (likely fixed by this change but I haven't verified).
glebm
force-pushed
the
selector-list-eq
branch
from
7f43f0f
to
3b1ac11
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements equality for selector lists in a cleaner and more efficient manner.
The previous version checked for nulls in the list. This one does not, because there shouldn't be any nulls in there and we don't want to mask the underlying problem if there are.
Related issue: #2666 (likely fixed by this change but I haven't verified).