Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix regressions 3.3.3 #1925

Closed
wants to merge 5 commits into from
Closed

Bugfix regressions 3.3.3 #1925

wants to merge 5 commits into from

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Feb 23, 2016

@xzyfer
Copy link
Contributor

xzyfer commented Feb 23, 2016

Remember to activate these specs before merging. Otherwise looks good. We need to come back around to how to do interpolation and binary operations. The Ruby Sass approaches are nice.

@xzyfer xzyfer added this to the 3.3.4 milestone Feb 23, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Feb 23, 2016

This doesn't fully patch #1907. The follow still produces the incorrect output.

foo {
  bar: '#{b}' + az;
}

@xzyfer
Copy link
Contributor

xzyfer commented Feb 23, 2016

This also appears to fix #1926

@lunelson lunelson mentioned this pull request Mar 17, 2016
Closed
@xzyfer xzyfer mentioned this pull request Mar 17, 2016
Merged
xzyfer pushed a commit to xzyfer/libsass that referenced this pull request Mar 17, 2016
@mgreter @xzyfer
Fix segfault with non existing extend and parent selector
6c18db1 
Cherry-picked from sass#1925.

Fixes sass#1916
Spec sass/sass-spec#732
@xzyfer xzyfer mentioned this pull request Mar 17, 2016
Merged
xzyfer pushed a commit to xzyfer/libsass that referenced this pull request Mar 17, 2016
@mgreter @xzyfer
Fix segfault with non existing extend and parent selector
748f097 
Cherry-picked from sass#1925.

Fixes sass#1916
Spec sass/sass-spec#732
@xzyfer xzyfer mentioned this pull request Mar 17, 2016
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Mar 17, 2016

I've cherry-picked all but a9c4215 into separate PRs. I wasn't sure what issue that in regards to.

@xzyfer xzyfer mentioned this pull request Mar 19, 2016
Closed
@xzyfer
Copy link
Contributor

xzyfer commented Mar 19, 2016

Superseded by #1958

@xzyfer xzyfer closed this Mar 19, 2016
@xzyfer xzyfer removed this from the 3.3.4 milestone Apr 10, 2016
@xzyfer xzyfer mentioned this pull request Apr 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Dev - Needs Review Dev - WIP Release - Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgreter @xzyfer