Even less warnings

[larsimmisch]

Two more patches, and then only one warning remains (and that should actually be taken care of properly)

The last patch, titled default statements and "control reaches end of non-void function" should be reviewed carefully. I've tried to do sensible things, but I was a bit on autopilot.

[akhleung]

Wow, thanks for the cleanup! I'll review that last patch this evening.

[larsimmisch]

You're welcome.

Do have a look at 8b24df9. That one is really a potential problem.

[larsimmisch]

Also, may I suggest that the C-API is changed?

I'd do something like:

struct sass_context {
  const char *output_string;
  int error_status;
  const char* error_message;
};

// options may be NULL
int sass_compile(const char *input, struct sass_context *ctx, struct sass_options *options);

// sass_compile_file never sets the output_string in sass_context and writes to output instead
int sass_compile_file(FILE *input, FILE *output, struct sass_context *ctx, struct sass_options *options);

I would omit sass_compile_folder. It's a friendly idea, but if there is an error, there is no way to signal where the error occurs.

Also, for the record: Yes, this isn't pretty, even uglier than the current version. But sass_context is only written to in this draft, which avoids a bit of confusion.

I think that sass_compile_file that outputs to a file would be nice, because on more memory constrained sustem (think Raspberry P)i, the result of he compilation might not fit into memory.

If you are interested, I can work on a patch.

[HamptonMakes]

lars- yeah, I'm up for that change. I like it.

Just have to make sure to coordinate this with the SassJS guys' work.

Or, were you helping with that too?

[larsimmisch]

No, I just helped out with the Python wrappers.

I'll be offline for a week now, but when I'm back, I'll try to come up with a patch and look at what the SassJS guys are up to.

[HamptonMakes]

Lars, I noticed you said there were no tests... there are! They are just in SassC... which is the
recommended way to dev on libsass.

I just added a note to the readme about this... 6b8405d