Skip to content

Identical subexpressions in op_color_number #3148

Closed
@ariccio

Description

@ariccio

I ran msvc code analysis while waiting for a heroku instance to deploy, and it found this code introduced in 95011cd in operators.cpp:

      if ((op == Sass_OP::DIV || op == Sass_OP::DIV) && rval == 0) {
        // comparison of Fixnum with Float failed?
        throw Exception::ZeroDivisionError(lhs, rhs);
      }

...that can't be right?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions