Throw a better error when trying to install with musl-libc #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
suggested changes
May 31, 2022
tool/utils.ts
Outdated
| if (process.platform !== 'linux') return; | ||
|
|
||
| const executable = await fs.readFile(process.execPath); | ||
| if (!executable.includes('libc.musl-x86_64.so.1')) return; |
There was a problem hiding this comment.
We should also consider aarch64 as well as other archs here.
- libc.musl-x86_64.so.1
- libc.musl-aarch64.so.1
- libc.musl-armv7.so.1
- libc.musl-armhf.so.1
- etc.
There was a problem hiding this comment.
I'm not intimately familiar with what strings those are likely to leave in the executable. Can you give me a list of strings to search for?
There was a problem hiding this comment.
There was a problem hiding this comment.
Would it make sense to check against '/lib/ld-musl-' and '/lib/libc.musl-' so it works regardless of architecture?
There was a problem hiding this comment.
It is extremely rare but multiple ld/libc can be installed in the same system at non-standard locations, so searching with /lib/ might miss some rare cases. If we want good performance in searching, libc.musl- is probably the best.
Goodwine
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.