Skip to content

feat: support reading proxy from env #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: support reading proxy from env #136

wants to merge 1 commit into from

Conversation

roland-reed
Copy link

Support reading proxy from environtment variables, as sometimes downloading from github.com fails.

Reading priority:

  • HTTPS_PROXY
  • HTTP_PROXY
  • https_proxy
  • http_proxy

Use https-proxy-agent under the hood.

@ntkme
Copy link
Contributor

ntkme commented Apr 21, 2022

I think #135 would be preferred over this as it is what npm uses.

@nex3 nex3 requested a review from jathak April 25, 2022 20:47
@jathak
Copy link
Member

jathak commented Apr 25, 2022 •
edited
Loading

Going to close this in favor of that then.

@jathak jathak closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak Awaiting requested review from jathak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roland-reed @ntkme @jathak