Skip to content

Make fetch happen #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Make fetch happen #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01d5d12
Await fs promises to avoid EPERMs
chrisuehlinger Apr 12, 2022
fbc3e97
Switch from node-fetch to make-fetch-happen
chrisuehlinger Apr 12, 2022
63f2202
Code review
nex3 Jun 13, 2022
6fc109f
Merge remote-tracking branch 'origin/main' into make-fetch-happen
nex3 Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"extract-zip": "^2.0.1",
"google-protobuf": "^3.11.4",
"immutable": "^4.0.0",
"node-fetch": "^2.6.0",
"make-fetch-happen": "^10.1.2",
"rxjs": "^7.4.0",
"semver": "^7.3.5",
"shelljs": "^0.8.4",
Expand All @@ -43,7 +43,7 @@
"@types/google-protobuf": "^3.7.2",
"@types/jest": "^27.0.2",
"@types/node": "^16.10.3",
"@types/node-fetch": "^2.5.7",
"@types/make-fetch-happen": "^9.0.2",
"@types/semver": "^7.3.4",
"@types/shelljs": "^0.8.8",
"@types/supports-color": "^8.1.1",
Expand Down
4 changes: 3 additions & 1 deletion tool/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

import {defaults as initMakeFetchHappen} from 'make-fetch-happen';
import extractZip = require('extract-zip');
import {promises as fs, existsSync, mkdirSync} from 'fs';
import fetch from 'node-fetch';
import * as p from 'path';
import * as shell from 'shelljs';
import {extract as extractTar} from 'tar';

import * as pkg from '../package.json';

const fetch = initMakeFetchHappen();

shell.config.fatal = true;

// The current platform's operating system. Throws if the operating system
Expand Down