-
Notifications
You must be signed in to change notification settings - Fork 365
Implement sass --embedded
in pure JS mode
#2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8d7d4de
to
7084da7
Compare
e66df5b
to
d53fcc5
Compare
d7e6206
to
b3794eb
Compare
9112b44
to
54fabf3
Compare
257b4fd
to
ac718ee
Compare
Applied most of the feedbacks. However, I have a awkward feeling about mixing classic js interop and new js interop in the same file, which is why I have lots of js specific things with new interop are only in embedded folder instead of in the generic folder. @nex3 I haven't changed these yet, as I want to hear what's your thought on this. |
Another note: The reason I tried to avoid classic interop and node_introp is that I couldn't get The new dart 3.3 js interop on the other hands was way more straight forward to use and debug. I got |
Closes #2325.
sass/embedded-host-node#344
Implementation
The actual isolate dispatcher and compilation dispatcher are nearly unchanged. However, I had to replace isolate with worker communication, and mock tons of small things that do not work on node.
Testing