Enable AOT build for windows-arm64 #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
windows-arm64-aot
branch
2 times, most recently
from
1c19226
to
d146921
Compare
ntkme
commented
Jul 23, 2024
ntkme
commented
Jul 23, 2024
nex3
approved these changes
Jul 23, 2024
|
Turns out there are two versions of powershell: PowerShell Core (7.x, crossbow platform, named as
|
|
The TLS certificate workaround is confirmed to be working. Now it turns out even |
|
Looks like everything worked! |
nex3
approved these changes
Jul 24, 2024
stof
reviewed
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another attempt to enable AOT snapshot for windows-arm64. It turns out the TLS issue we're seeing is likely not a windows runner bug but a windows feature and a dart bug: dart-lang/sdk#52266
In summary, the problem is that windows would lazily initialize some trusted certificates, but dart does not support this lazy initialization. The x86_64 windows runner image likely already have the missing root certificates initialized at some point by other calls made to other google services during its image provisioning, but this arm64 image isn't the same.
@nex3 I would like to give this another try, but I don't have access to arm64 runners. If you can push this commit to a branch directly in sass/dart-sass repo, you can use "run workflow" feature to test it without needing to merge this PR first.