-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows-arm64 release #2274
Conversation
Can you add a comment here indicating that we can't use the shared workflow and linking to the GitHub discussion? |
https://github.com/sass/dart-sass/actions/workflows/build-windows.yml @nex3 By the way, there should be a "run workflow" button on page the linked above. After we merge this PR, you can use the "run workflow" button to test it out, that it will build the windows artifacts without an actual release. I cannot personally try it as I do not have access to see the button, so it would be very helpful if you can trigger a run after merging to see if there is any other issue or not. |
It looks like dart-sdk on windows 11 for arm might be missing CA certs like this issue: dart-lang/pub#1882 |
@nex3 Can we try change the command to |
Rerunning with |
Here's the result, although I'm not sure how much more information it gives us. I think it may be better at this point to just resurrect #2275 to get releases back on track. |
It looks indeed like missing ca certs. I think unable to get local issuer means unable to get parent certificate for the server certificate. This parent is either an intermediate certificate (usually served by server) or a root ca (need to be trusted locally). So most likely there is an issue with the default root CA config. |
This PR attempts to fix the release failure in https://github.com/sass/dart-sass/actions/runs/9864595353/job/27240444712