Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement access tracking for containingUrl #2220

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Apr 12, 2024

This PR adds a CanonicalizeContext class in dart which is able to track if containingUrl is accessed or not, it also changes the dart2js JSCanonicalizeContext class to be a wrapper, so that the containingUrl in JS would lazily access the dart containingUrl method instead of eagerly during construction. Finally for embedded host, this adds a containingUrlWithoutMarking method that allow the serialization of embedded protocol without marking, and we can mark it accordingly depends on the result from host.

sass/sass#3835
sass/embedded-host-node#285

@ntkme ntkme force-pushed the access-containing-url branch 5 times, most recently from 8b90f10 to 71370a3 Compare April 12, 2024 04:14
@ntkme ntkme marked this pull request as ready for review April 12, 2024 04:35
@ntkme ntkme force-pushed the access-containing-url branch 2 times, most recently from f0336f7 to c467ae7 Compare April 12, 2024 15:54
lib/src/embedded/importer/file.dart Outdated Show resolved Hide resolved
lib/src/importer/async.dart Outdated Show resolved Hide resolved
lib/src/importer/canonicalize_context.dart Outdated Show resolved Hide resolved
lib/src/importer/utils.dart Outdated Show resolved Hide resolved
lib/src/js/utils.dart Outdated Show resolved Hide resolved
lib/src/import_cache.dart Outdated Show resolved Hide resolved
@ntkme ntkme force-pushed the access-containing-url branch 4 times, most recently from d6979b9 to 5929113 Compare April 13, 2024 02:01
lib/src/importer/canonicalize_context.dart Outdated Show resolved Hide resolved
lib/src/embedded/importer/file.dart Outdated Show resolved Hide resolved
lib/src/importer/canonicalize_context.dart Outdated Show resolved Hide resolved
lib/src/importer/canonicalize_context.dart Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants