Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for the windows archives #22

Merged
merged 3 commits into from
Nov 2, 2016
Merged

fixes for the windows archives #22

merged 3 commits into from
Nov 2, 2016

Conversation

m4r71n
Copy link
Contributor

@m4r71n m4r71n commented Nov 2, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nex3
Copy link
Contributor

nex3 commented Nov 2, 2016

Please run pub run grinder format to reformat the Dart change.

@m4r71n
Copy link
Contributor Author

m4r71n commented Nov 2, 2016

Ah Thx. I wondered why the travis build failed but now I've seen the exact reason

@nex3
Copy link
Contributor

nex3 commented Nov 2, 2016

Make sure to sign the CLA as well!

@m4r71n
Copy link
Contributor Author

m4r71n commented Nov 2, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@nex3 nex3 merged commit 446cb84 into sass:master Nov 2, 2016
@nex3
Copy link
Contributor

nex3 commented Nov 2, 2016

Thanks for the patch!

nex3 added a commit that referenced this pull request May 10, 2023
Partially addresses sass/embedded_protocol#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants