Upload releases for musl-libc and android #2149
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| name: Build for android | ||
|
|
||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - arch: x64 | ||
| lib: lib64 | ||
| platform: linux/amd64 | ||
| - arch: ia32 | ||
| lib: lib | ||
| platform: linux/amd64 | ||
| - arch: arm64 | ||
| lib: lib64 | ||
| platform: linux/arm64 | ||
| - arch: arm | ||
| lib: lib | ||
| platform: linux/arm64 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| with: | ||
| image: tonistiigi/binfmt:master # need qemu >= 7.0.0 | ||
|
|
||
| - name: Compile Protobuf | ||
| run: | | ||
| docker run --rm -i \ | ||
| --volume "$PWD:$PWD" \ | ||
| --workdir "$PWD" \ | ||
| docker.io/library/dart <<'EOF' | ||
| set -e | ||
| curl -fsSL -H "Authorization: Bearer ${{ github.token }}" "https://github.com/bufbuild/buf/releases/latest/download/buf-$(uname -s)-$(uname -m).tar.gz" | tar -xzC /usr/local --strip-components 1 | ||
| dart pub get | ||
| dart run grinder protobuf | ||
| EOF | ||
|
|
||
| - name: Build | ||
| run: | | ||
| docker run --rm -i \ | ||
| --platform ${{ matrix.platform }} \ | ||
| --privileged \ | ||
| --volume "$PWD:$PWD" \ | ||
| --workdir "$PWD" \ | ||
| ghcr.io/dart-android/dart <<'EOF' | ||
| set -e | ||
| export DART_SDK=/system/${{ matrix.lib }}/dart | ||
| export PATH=$DART_SDK/bin:$PATH | ||
| dart pub get | ||
| dart run grinder pkg-standalone-android-${{ matrix.arch }} | ||
| EOF | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: build-android-${{ matrix.arch }} | ||
| path: build/*.tar.gz | ||
| if-no-files-found: error | ||
| compression-level: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| name: Build for linux-musl | ||
|
|
||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - arch: x64 | ||
| platform: linux/amd64 | ||
| - arch: ia32 | ||
| platform: linux/386 | ||
| - arch: arm64 | ||
| platform: linux/arm64 | ||
| - arch: arm | ||
| platform: linux/arm/v7 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
|
|
||
| - name: Compile Protobuf | ||
| run: | | ||
| docker run --rm -i \ | ||
| --volume "$PWD:$PWD" \ | ||
| --workdir "$PWD" \ | ||
| docker.io/library/dart <<'EOF' | ||
| set -e | ||
| curl -fsSL -H "Authorization: Bearer ${{ github.token }}" "https://github.com/bufbuild/buf/releases/latest/download/buf-$(uname -s)-$(uname -m).tar.gz" | tar -xzC /usr/local --strip-components 1 | ||
| dart pub get | ||
| dart run grinder protobuf | ||
| EOF | ||
|
|
||
| # There is a bug in qemu's mremap causing pthread_getattr_np in musl to stuck in a loop on arm. | ||
ntkme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # Unless qemu fixes the bug or we get a real linux-arm runner, we cannot build aot-snapshot | ||
| # for arm on CI. So, we create an kernel snapshot for arm build in amd64 container instead. | ||
ntkme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # | ||
| # In addition, we need to rename the artifact from -linux- to -linux-musl- to avoid conflict | ||
| # with glibc builds. | ||
ntkme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - name: Build | ||
| run: | | ||
| docker run --rm -i \ | ||
| --platform ${{ matrix.arch == 'arm' && 'linux/amd64' || matrix.platform }} \ | ||
| --volume "$PWD:$PWD" \ | ||
| --workdir "$PWD" \ | ||
| ghcr.io/dart-musl/dart <<'EOF' | ||
| set -e | ||
| dart pub get | ||
| dart run grinder pkg-standalone-linux-${{ matrix.arch }} | ||
| find build -name '*.tar.gz' -print0 | xargs -0 -n 1 -- sh -xc 'mv "$1" "$(echo "$1" | sed -e "s/linux/linux-musl/")"' -- | ||
| EOF | ||
|
|
||
| # The kernel snapshot created for arm in the previous step is bundling a glibc based dart runtime | ||
| # due to how cli_pkg download the sdk for building non-native platforms. Therefore we need to | ||
ntkme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # replace it with musl-libc based dart runtime to create a working linux-musl-arm package. | ||
|
There was a problem hiding this comment. Would it make sense to build more of this logic into There was a problem hiding this comment. That's certainly possible, but I would consider that at a later time due to the complexity. The problem mainly lies on dart-sdk only have the knowledge of itself running as some "linux" variant, and have no concept of "linux-gnu" or "linux-musl", which would require lots of structural changes to cli_pkg to accommodate this. Also, we need a way to know what is the current running variant, that either the current running dart-sdk need to be able to tell what kind of linux variant by itself, or we need to parse the dart executable file as ELF, and then detect what it is based on the interpreter field. There was a problem hiding this comment. Would it be possible for your fork to add "musl" somewhere in the There was a problem hiding this comment. My "fork" does not modify any dart-sdk source code. Only thing it does is running a CI/CD with a different build toolchain for building dart-sdk on alpine linux. The reason I said it is difficult to do in either dart or cli_pkg is because the platform logic in dart is closely tied to the I don't think change the version string is the correct behavior. I think the right way to deal with this in dart-sdk would be to provide new API that returns the "target triplet". For example, in ruby we have |
||
| - name: Fix Dart Runtime | ||
| if: matrix.arch == 'arm' | ||
| run: | | ||
| docker run --rm -i \ | ||
| --platform ${{ matrix.platform }} \ | ||
| --volume $PWD:$PWD \ | ||
| --workdir $PWD \ | ||
| ghcr.io/dart-musl/dart <<'EOF' | ||
| set -e | ||
| apk add --no-cache tar | ||
| cd build | ||
| DART_RUNTIME=$(tar -tzf *.tar.gz --wildcards "*/src/dart") | ||
| tar -xzf *.tar.gz | ||
| cp $DART_SDK/bin/dart $DART_RUNTIME | ||
| tar -czf *.tar.gz "$(dirname "$(dirname "$DART_RUNTIME")")" | ||
| EOF | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: build-linux-musl-${{ matrix.arch }} | ||
| path: build/*.tar.gz | ||
| if-no-files-found: error | ||
| compression-level: 0 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Build for linux | ||
|
|
||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - arch: x64 | ||
| platform: linux/amd64 | ||
| - arch: ia32 | ||
| platform: linux/amd64 | ||
| - arch: arm | ||
| platform: linux/arm/v7 | ||
| - arch: arm64 | ||
| platform: linux/arm64 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
|
|
||
| - name: Compile Protobuf | ||
| run: | | ||
| docker run --rm -i \ | ||
| --volume "$PWD:$PWD" \ | ||
| --workdir "$PWD" \ | ||
| docker.io/library/dart <<'EOF' | ||
| set -e | ||
| curl -fsSL -H "Authorization: Bearer ${{ github.token }}" "https://github.com/bufbuild/buf/releases/latest/download/buf-$(uname -s)-$(uname -m).tar.gz" | tar -xzC /usr/local --strip-components 1 | ||
| dart pub get | ||
| dart run grinder protobuf | ||
| EOF | ||
|
|
||
| - name: Build | ||
| run: | | ||
| docker run --rm -i \ | ||
| --platform ${{ matrix.platform }} \ | ||
| --volume "$PWD:$PWD" \ | ||
| --workdir "$PWD" \ | ||
| docker.io/library/dart:latest <<'EOF' | ||
| set -e | ||
| dart pub get | ||
| dart run grinder pkg-standalone-linux-${{ matrix.arch }} | ||
| EOF | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: build-linux-${{ matrix.arch }} | ||
| path: build/*.tar.gz | ||
| if-no-files-found: error | ||
| compression-level: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Build for macos | ||
|
|
||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build | ||
|
|
||
| runs-on: ${{ matrix.runner }} | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - arch: x64 | ||
| runner: macos-latest | ||
| # https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/ | ||
| - arch: arm64 | ||
| runner: macos-latest-xlarge | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: ./.github/util/initialize | ||
| with: {github-token: "${{ github.token }}"} | ||
|
|
||
| - name: Build | ||
| run: dart run grinder pkg-standalone-macos-${{ matrix.arch }} | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: build-macos-${{ matrix.arch }} | ||
| path: build/*.tar.gz | ||
| if-no-files-found: error | ||
| compression-level: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Build for windows | ||
|
|
||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build | ||
|
|
||
| runs-on: ${{ matrix.runner }} | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - arch: x64 | ||
| runner: windows-latest | ||
| - arch: ia32 | ||
| runner: windows-latest | ||
| # - arch: arm64 | ||
| # runner: windows-latest | ||
ntkme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: ./.github/util/initialize | ||
| with: {github-token: "${{ github.token }}"} | ||
|
|
||
| - name: Build | ||
| run: dart run grinder pkg-standalone-windows-${{ matrix.arch }} | ||
|
|
||
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: build-windows-${{ matrix.arch }} | ||
| path: build/*.zip | ||
| if-no-files-found: error | ||
| compression-level: 0 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we ever had anyone request native Android support for Dart Sass? I'm not sure this is worth the trouble.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a few people asking this from jekyll community. Interestingly, now there are some (very few) active users:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess another point is SWC (https://swc.rs/) also has native android support: https://www.npmjs.com/package/@swc/core-android-arm64
This means there are people out there using android for web development...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that dart-sass has an Android variant, I actually had a request to get my embedded host working on Android:
larsgrefer/dart-sass-java#461 (comment)