Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dartdoc from 6.3.0 to 7.0.0 #2118

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2023

Bumps dartdoc from 6.3.0 to 7.0.0.

Changelog

Sourced from dartdoc's changelog.

7.0.0

  • Require analyzer: ^6.2.0.
  • Remove all @deprecated elements.
  • Fix sidebar links in leaf pages. (#3510)
  • Do not hide stack trace of DartdocFailures. (#3505)
  • Rank libraries lower than classes and class modifiers.
  • Remove deprecated <nodoc> syntax.
  • Deprecate the {@example} directive.
  • Remove support for the four-argument {@animation} directive format.
  • Remove old options, dropTextFrom and hideSdkText.
  • Rename Feature to Attribute, to avoid confusion with language features. The corresponding template partials are also renamed. (#3499)
  • Some support for extension types is enabled.
  • Move all grinder tasks to package:args commands.
  • Remove Canonicalization.canonicalLibrary and Category.canonicalLibrary and Package.canonicalLibrary.
  • Make Category.categoryDefinition and Library.exportedInLibraries private.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added Dart Issues particular to the pure Dart distribution dependencies Pull requests that update a dependency file labels Oct 16, 2023
@Goodwine
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pub/dartdoc-7.0.0 branch from 14f355c to 97d6111 Compare October 16, 2023 21:46
@Goodwine
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pub/dartdoc-7.0.0 branch from 5783eac to bcda10b Compare October 16, 2023 23:57
@Goodwine
Copy link
Member

It looks like dartdoc changed how we get the names which synchronize.dart depends on to remove things like Async as a prefix from many types, so I'll look into that probably tomorrow :)

@Goodwine Goodwine self-requested a review October 17, 2023 00:06
Bumps [dartdoc](https://github.com/dart-lang/dartdoc) from 6.3.0 to 7.0.0.
- [Release notes](https://github.com/dart-lang/dartdoc/releases)
- [Changelog](https://github.com/dart-lang/dartdoc/blob/main/CHANGELOG.md)
- [Commits](https://github.com/dart-lang/dartdoc/commits)

---
updated-dependencies:
- dependency-name: dartdoc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pub/dartdoc-7.0.0 branch from bcda10b to a7c49ec Compare October 17, 2023 21:25
@Goodwine
Copy link
Member

ok this is because dartdoc forces pulling analyzer v6.3 up from v5.13, the grinder script seems to be working, but optional parameters (that seems to be the issue) no longer seem to be processed 🤔

@nex3
Copy link
Contributor

nex3 commented Oct 17, 2023

The analyzer API periodically releases strange and undocumented breaking changes. We probably need to update the visitor somehow—do you want to take a look at it or shall I?

@Goodwine
Copy link
Member

The analyzer API periodically releases strange and undocumented breaking changes. We probably need to update the visitor somehow—do you want to take a look at it or shall I?

I already did :)

@Goodwine Goodwine requested a review from nex3 October 18, 2023 01:03
@Goodwine Goodwine merged commit ac25a70 into main Oct 18, 2023
44 checks passed
@Goodwine Goodwine deleted the dependabot/pub/dartdoc-7.0.0 branch October 18, 2023 01:12
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Nov 17, 2023
* feature.color-4:
  Poke CI
  Update link to Node.js releases page (sass#2131)
  Write implementation documentation (sass#2042)
  Remove dead code (sass#2129)
  Add compatibility with Node.js 21.0.0 (sass#2128)
  Bump lints from 2.1.1 to 3.0.0 (sass#2126)
  Bump dartdoc from 6.3.0 to 7.0.0 (sass#2118)
  Cut a release (sass#2120)
  Update pubspec and changelog for sass/embedded-host-node#257 (sass#2116)
  Fix crash in browser when running alongside NextJS (sass#2114)
  Cut another release (sass#2111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dart Issues particular to the pure Dart distribution dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants