Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't separate out media queries after one has bubbled #1933

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Don't separate out media queries after one has bubbled #1933

merged 2 commits into from
Apr 11, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Apr 11, 2023

@nex3 nex3 requested a review from Goodwine April 11, 2023 01:07
Goodwine
Goodwine approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the synchronized file, but LGTM

@nex3 nex3 merged commit c55235d into main Apr 11, 2023
@nex3 nex3 deleted the media-merge branch April 11, 2023 22:44
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Apr 12, 2023
@jgerigmeyer
Merge branch 'main' into browser
49182bd 
* main:
  Don't separate out media queries after one has bubbled (sass#1933)
  Allow global Sass function colliding with CSS native functions to use CSS variables (sass#1926)
@colinrotherham colinrotherham mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nested at-rules breaks at-rule merging
2 participants
@nex3 @Goodwine