Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Version support #95

Closed
duncanmapes opened this issue Jan 11, 2017 · 3 comments
Closed

Node Version support #95

duncanmapes opened this issue Jan 11, 2017 · 3 comments

Comments

@duncanmapes
Copy link

I see you have the engine set to >=0.10.0. Is that the intended support, because I am having some issues with v4.x?

@nex3
Copy link
Contributor

nex3 commented Jan 11, 2017

I think I looked at which versions supported the narrow slice of Node APIs we're using. What sorts of problems are you running into?

@srawlins
Copy link
Contributor

For what its worth, the exit code tests in test/cli_shared.dart under node, on Linux:

  • fail for me with node v0.10.24 (the processes always exit 0 instead of the intended exit code) and
  • pass for me with node v7.10.0.

@nex3
Copy link
Contributor

nex3 commented Jun 1, 2017

Ah, it does look like process.exitCode was added in v0.11.8. I'll update the version constraint accordingly.

@nex3 nex3 closed this as completed in b02da78 Jun 1, 2017
nex3 added a commit that referenced this issue May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants