Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with 1.0.0-alpha.4 on Windows #51

Closed
AngusFu opened this issue Nov 23, 2016 · 3 comments · Fixed by mbullington/node_preamble.dart#1
Closed

Error with 1.0.0-alpha.4 on Windows #51

AngusFu opened this issue Nov 23, 2016 · 3 comments · Fixed by mbullington/node_preamble.dart#1
Labels

Comments

@AngusFu
Copy link

AngusFu commented Nov 23, 2016

On Windows CMD and GitBash, it seems path seperator often cause some error.

Test the following code, where ./test.scss is any given valid scss file in the same folder:

var sass = require('dart-sass');
var res = sass.renderSync({ file: './test.scss' });
console.log(res);

Then got:

image

In dart.Uri_parse‘s body, insert a new line at the begining, uri = uri.replace(/\\/g, '/') will work,

So this maybe a problem to be solved.

@AngusFu AngusFu changed the title Error with 1.0.0-alpha.4 on Windows Error with 1.0.0-alpha.4 on Windows Nov 23, 2016
@nex3
Copy link
Contributor

nex3 commented Nov 24, 2016

This looks like it could be a bug in the glue code we use for Node.js, or possibly even in Dart itself. I may need to track down a Windows machine to test this properly.

@nex3 nex3 added the bug label Nov 24, 2016
@nschonni
Copy link
Contributor

Might be a good idea to setup Appveyor for this repo to catch the Windows specific issues

@nex3
Copy link
Contributor

nex3 commented Dec 2, 2016

Might be a good idea to setup Appveyor for this repo to catch the Windows specific issues

Currently our only tests are sass-spec tests of the language itself, which aren't likely to vary from OS to OS. We should probably add some tests for the CLI(s), though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants