-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: implement the logic for running python stored programs #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b06993a
feat: implement the logic for running python stored programs
sabhas a9b25b8
chore: added specs for stp
sabhas 4c11082
chore: addressed comments
sabhas 8780b80
fix: update default content type for python and js runtimes
sabhas 882bedd
fix: add a new variable _SASJS_WEBOUT_HEADERS to code.js and code.py
sabhas 02e88ae
fix: update content for code.sas file
sabhas bd97363
chore: quick fixes
sabhas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { isWindows } from '@sasjs/utils' | ||
| import { PreProgramVars, Session } from '../../types' | ||
| import { generateFileUploadPythonCode } from '../../utils' | ||
| import { ExecutionVars } from './' | ||
|
|
||
| export const createPythonProgram = async ( | ||
| program: string, | ||
| preProgramVariables: PreProgramVars, | ||
| vars: ExecutionVars, | ||
| session: Session, | ||
| weboutPath: string, | ||
| headersPath: string, | ||
| tokenFile: string, | ||
| otherArgs?: any | ||
| ) => { | ||
| const varStatments = Object.keys(vars).reduce( | ||
| (computed: string, key: string) => `${computed}${key} = '${vars[key]}';\n`, | ||
| '' | ||
| ) | ||
|
|
||
| const preProgramVarStatments = ` | ||
| _SASJS_SESSION_PATH = '${ | ||
| isWindows() ? session.path.replace(/\\/g, '\\\\') : session.path | ||
| }'; | ||
| _WEBOUT = '${isWindows() ? weboutPath.replace(/\\/g, '\\\\') : weboutPath}'; | ||
| _SASJS_WEBOUT_HEADERS = '${headersPath}'; | ||
| _SASJS_TOKENFILE = '${ | ||
| isWindows() ? tokenFile.replace(/\\/g, '\\\\') : tokenFile | ||
| }'; | ||
| _SASJS_USERNAME = '${preProgramVariables?.username}'; | ||
| _SASJS_USERID = '${preProgramVariables?.userId}'; | ||
| _SASJS_DISPLAYNAME = '${preProgramVariables?.displayName}'; | ||
| _METAPERSON = _SASJS_DISPLAYNAME; | ||
| _METAUSER = _SASJS_USERNAME; | ||
| SASJSPROCESSMODE = 'Stored Program'; | ||
| ` | ||
|
|
||
| const requiredModules = `import os` | ||
|
|
||
| program = ` | ||
| # runtime vars | ||
| ${varStatments} | ||
|
|
||
| # dynamic user-provided vars | ||
| ${preProgramVarStatments} | ||
|
|
||
| # change working directory to session folder | ||
| os.chdir(_SASJS_SESSION_PATH) | ||
|
|
||
| # actual job code | ||
| ${program} | ||
|
|
||
| ` | ||
| // if no files are uploaded filesNamesMap will be undefined | ||
| if (otherArgs?.filesNamesMap) { | ||
| const uploadPythonCode = await generateFileUploadPythonCode( | ||
| otherArgs.filesNamesMap, | ||
| session.path | ||
| ) | ||
|
|
||
| // If any files are uploaded, the program needs to be updated with some | ||
| // dynamically generated variables (pointers) for ease of ingestion | ||
| if (uploadPythonCode.length > 0) { | ||
| program = `${uploadPythonCode}\n` + program | ||
| } | ||
| } | ||
| return requiredModules + program | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.