Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move pull request template #420

Merged

Conversation

vvatanabe
Copy link
Collaborator

@sashabaranov
Oops, my bad. According to GitHub's rules, it seems we need to put the pull request template in .github/PULL_REQUEST_TEMPLATE.md for it to be applied when creating a pull request.

And I added a heads-up about BREAKING_CHANGES to the PR template. (#412 (comment))

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #420 (53696d4) into master (9c99f36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          17       17           
  Lines         690      690           
=======================================
  Hits          669      669           
  Misses         15       15           
  Partials        6        6           

@sashabaranov
Copy link
Owner

sashabaranov commented Jun 30, 2023

🙌 Thank you!

@sashabaranov sashabaranov merged commit 1efcf2d into sashabaranov:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants