Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Retrieve model API (#340) #341

Merged

Conversation

vvatanabe
Copy link
Collaborator

@vvatanabe vvatanabe commented Jun 3, 2023

This is a pull request for #340, I implemented the Retrieve model API.

I added some test code to the TestClientReturnsRequestBuilderErrors function and golangci-lint threw the following error.

client_test.go:160:1: cognitive complexity 21 of func `TestClientReturnsRequestBuilderErrors` is high (> 20) (gocognit)

It seems that the cognitive complexity has increased. I refactored the TestClientReturnsRequestBuilderErrors function to reduce its cognitive complexity. => b1cb1fe

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #341 (b1cb1fe) into master (61ba5f3) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   92.45%   92.54%   +0.09%     
==========================================
  Files          18       18              
  Lines         636      644       +8     
==========================================
+ Hits          588      596       +8     
  Misses         35       35              
  Partials       13       13              
Impacted Files Coverage Δ
models.go 100.00% <100.00%> (ø)

@vvatanabe
Copy link
Collaborator Author

@sashabaranov Please check this PR.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sashabaranov sashabaranov merged commit 6830e00 into sashabaranov:master Jun 5, 2023
@vvatanabe vvatanabe deleted the support-retrieve-model-api-340 branch June 5, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants